Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix HfExampleModels.find_hf_info #12223

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[Bugfix] Fix HfExampleModels.find_hf_info #12223

merged 1 commit into from
Jan 20, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jan 20, 2025 •
edited by github-actions bot
Loading

Fix a CI bug introduced in #12203

Multi-modal tests should pass for real now.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 20, 2025
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

youkaichao
youkaichao approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 20, 2025 13:01
@DarkLight1337 DarkLight1337 merged commit 18572e3 into vllm-project:main Jan 20, 2025
33 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-find-hf-info branch January 20, 2025 15:35
@kzawora-intel kzawora-intel mentioned this pull request Jan 21, 2025
Open
mhendrey pushed a commit to mhendrey/vllm that referenced this pull request Jan 23, 2025
@DarkLight1337 @mhendrey
[Bugfix] Fix HfExampleModels.find_hf_info (vllm-project#12223)
a5d57f1 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Matthew Hendrey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

@mgoin mgoin mgoin approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @mgoin @youkaichao